Skip to content

fix: method signature from reqeust to request #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

fix: method signature from reqeust to request #18

merged 1 commit into from
Jul 7, 2025

Conversation

@Morgadoooo
Copy link
Contributor

@Morgadoooo Morgadoooo commented Jul 7, 2025 •
edited
Loading

This PR adds support for retrieving the key type in the response of the /meta endpoint in CubeJS.

When designing views to be queried via the REST API, it is useful to know all available views (cubes) and their key types upfront. This enhancement makes the /meta endpoint more informative, helping consumers programmatically discover and work with the designed views more effectively.

Also, proposition to change the naming from reqeust to request for method signature that use them

@Morgadoooo
Copy link
Contributor Author

Morgadoooo commented Jul 7, 2025

Didn't saw this one #17 before proposing mine. I'm fine with closing my PR, but i'd say the reqeust can be confusing

@mharrisb1
Copy link
Owner

mharrisb1 commented Jul 7, 2025

@Morgadoooo I will use #17 as the PR for adding type but I would still like to merge your PR since it fixes some typos. I will change the title of the PR to reflect that change specifically. Please revert the change for adding type and the enum (though appreciated) as well as the version bump from this PR so I can merge.

Also for future reference:

  1. I prefer using literals as opposed to enums for Pydantic type validation. This will keep it consistent with other type definitions in this package
  2. I update the version in a separate step outside of PRs so no need to do that manually

Thanks for the contribution. Looking forward to more 👍

mharrisb1
mharrisb1 requested changes Jul 7, 2025
View reviewed changes
@Morgadoooo Morgadoooo force-pushed the feat/v1_meta_response branch from 8b7e90a to 214431e Compare July 7, 2025 17:29
@Morgadoooo Morgadoooo changed the title feat: add type attribute to V1CubeMeta fix: method signature from reqeust to request Jul 7, 2025
@mharrisb1 mharrisb1 merged commit f083849 into mharrisb1:main Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mharrisb1 mharrisb1 mharrisb1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Morgadoooo @mharrisb1